lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Jul 2015 16:32:59 -0700 (PDT) From: David Miller <davem@...emloft.net> To: daniel@...earbox.net Cc: jhs@...atatu.com, vyasevic@...hat.com, nhorman@...driver.com, David.Laight@...LAB.COM, netdev@...r.kernel.org, tuexen@...muenster.de Subject: Re: [PATCH net] net: sctp: stop spamming klog with rfc6458, 5.3.2. deprecation warnings From: Daniel Borkmann <daniel@...earbox.net> Date: Wed, 22 Jul 2015 16:31:49 +0200 > Back then when we added support for SCTP_SNDINFO/SCTP_RCVINFO from > RFC6458 5.3.4/5.3.5, we decided to add a deprecation warning for the > (as per RFC deprecated) SCTP_SNDRCV via commit bbbea41d5e53 ("net: > sctp: deprecate rfc6458, 5.3.2. SCTP_SNDRCV support"), see [1]. > > Imho, it was not a good idea, and we should just revert that message > for a couple of reasons: > > 1) It's uapi and therefore set in stone forever. > > 2) To be able to run on older and newer kernels, an SCTP application > would need to probe for both, SCTP_SNDRCV, but also SCTP_SNDINFO/ > SCTP_RCVINFO support, so that on older kernels, it can make use > of SCTP_SNDRCV, and on newer kernels SCTP_SNDINFO/SCTP_RCVINFO. > In my (limited) experience, a lot of SCTP appliances are migrating > to newer kernels only ve(ee)ry slowly. > > 3) Some people don't have the chance to change their applications, > f.e. due to proprietary legacy stuff. So, they'll hit this warning > in fast path and are stuck with older kernels. > > But i.e. due to point 1) I really fail to see the benefit of a warning. > So just revert that for now, the issue was reported up Jamal. > > [1] http://thread.gmane.org/gmane.linux.network/321960/ > > Reported-by: Jamal Hadi Salim <jhs@...atatu.com> > Signed-off-by: Daniel Borkmann <daniel@...earbox.net> Applied, thanks Daniel. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists