| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Jul 2015 00:22:43 +0200 From: Hannes Frederic Sowa <hannes@...essinduktion.org> To: roopa <roopa@...ulusnetworks.com> Cc: davem@...emloft.net, tgraf@...g.ch, netdev@...r.kernel.org Subject: Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output Hi roopa, On Tue, Jul 28, 2015, at 21:28, roopa wrote: > On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: > > Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do > > that and don't have a run-time dependency on IPv6 at all (for the cost > > of a function pointer). > ipv6_stub_impl.ipv6_dst_lookup seems to require sk today. > But it only needs it to get 'net' in the beginning and sk is optional > afterwards. > I will submit a patch to add 'net' as an arg to ipv6_dst_lookup. > Users of ipv6_dst_lookup are few and that seems like an easy change and > helps my patch. > If you or others think otherwise, pls let me know. No need to extend this function at any cost. Simply add your own function pointer to the struct if needed. Probably you have to move the ipv6_stub = &ipv6_stub_impl; initialization in inet6_init down so you don't expose the function pointer too early and thus it races with initialization (and error handling seems to be incorrect in this function, too). Thanks, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists