lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 02 Aug 2015 17:18:54 -0700 (PDT) From: David Miller <davem@...emloft.net> To: Yuval.Mintz@...gic.com Cc: netdev@...r.kernel.org, dan.carpenter@...cel.com, Ariel.Elior@...gic.com Subject: Re: [PATCH net-next] bnx2x: Correct logic for pvid configuration. From: Yuval Mintz <Yuval.Mintz@...gic.com> Date: Sun, 2 Aug 2015 12:42:41 +0300 > Commit 05cc5a39ddb7 ("bnx2x: add vlan filtering offload") has introduced > an incorrect logic for checking whether pvid should be configured for > a vf, causing the hypervisor driver to send unneeded ramrods for all of > the vfs each time a pvid has changed. > > Reported-by: Dan Carpenter <dan.carpenter@...cle.com> > Signed-off-by: Yuval Mintz <Yuval.Mintz@...gic.com> > Signed-off-by: Ariel Elior <Ariel.Elior@...gic.com> > --- > Looks like this has been hidden by the fact that > VLAN_VALID == (1 << MAC_ADDR_VALID). > Since MAC is almost always set by the hypervisor it simply caused > additional ramrods to be sent instead of preventing the feature. Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists