lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Aug 2015 10:44:02 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: roopa@...ulusnetworks.com Cc: "Eric W. Biederman" <ebiederm@...ssion.com>, netdev@...r.kernel.org Subject: re: af_mpls: fix undefined reference to ip6_route_output Hello Roopa, I have a concern about patch bf21563acc1d: "af_mpls: fix undefined reference to ip6_route_output" from Jul 30, 2015. net/mpls/af_mpls.c 450 451 dev = find_outdev(net, cfg); 452 if (IS_ERR(dev)) { find_outdev() used to return NULL pointers but now it only returns NULL if cfg->rc_via_table == NEIGH_LINK_TABLE or dev_get_by_index() fails. I think it could lead to a NULL dereference and we don't check for that here. Returning a mix of error pointers and NULL is bad style, it needs a big comment at the top of the function if it's deliberate. 453 err = PTR_ERR(dev); 454 dev = NULL; 455 goto errout; 456 } regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists