netdev - Re: [PATCH] r8169:Fill with zero Tx descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 5 Aug 2015 15:42:36 +0200
From:	Ivan Vecera <ivecera@...hat.com>
To:	Corcodel Marian <corcodel.marian@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] r8169:Fill with zero Tx descriptors

On 5.8.2015 12:46, Corcodel Marian wrote:
>   This patch fill with zero Tx descriptors before use.Is only
>   on    part by more patches but is critical.(critical)
>
>
> Signed-off-by: Corcodel Marian <corcodel.marian@...il.com>
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 3df51fa..bf78f94 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -7589,7 +7589,7 @@ static int rtl_open(struct net_device *dev)
>   	 * Rx and Tx descriptors needs 256 bytes alignment.
>   	 * dma_alloc_coherent provides more.
>   	 */
> -	tp->TxDescArray = dma_alloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
> +	tp->TxDescArray = dma_zalloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
>   					     &tp->TxPhyAddr, GFP_KERNEL);
>   	if (!tp->TxDescArray)
>   		goto err_pm_runtime_put;
>
Why? Why is zero-filling of tx-ring critical???

Ivan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html