netdev - Re: [PATCH net] gianfar: Restore link state settings after MAC reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2015 21:26:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	claudiu.manoil@...escale.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] gianfar: Restore link state settings after MAC
 reset

From: Claudiu Manoil <claudiu.manoil@...escale.com>
Date: Thu, 13 Aug 2015 16:50:37 +0300

> There are some MAC registers that need to be kept in sync
> with the link state parameters, see adjust_link().
> However, after a MAC soft reset default values for
> these registers are assumed.  In some cases (excepting
> if down/ if up for example) adjust_link() does not see
> that these values were reset to default because the
> priv->old* link parameters were left unchanged.
> So, reset the priv->old* link params as well during a
> MAC reset to let adjust_link() restore the MAC link
> settings to the actual link state values.
> 
> Fixes following case, for example:
> Setting link to 100M, changing MTU (implies MAC reset),
> link state remains unchanged to 100M but MAC registers
> were reset to default (1G) breaking the connectivity w/
> the PHY.  Closing and re-opening the interface would
> restore the MAC link parameters to the correct values.
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@...escale.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html