netdev - Re: [PATCH net-next] rocker: add debugfs support to dump internal tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2015 21:29:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	sfeldma@...il.com, netdev@...r.kernel.org, jiri@...nulli.us
Subject: Re: [PATCH net-next] rocker: add debugfs support to dump internal
 tables

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Thu, 13 Aug 2015 08:46:39 -0700

> Looks good.
> A couple caveats about debugfs.
> 1) Don't use it for API's not available elsewhere. You don't want it to become
>    a stable API which other tools get tied too.
> 2) Best to make it an optional config option (dependent on DEBUGFS)
>    that way it is possible to have rocker support w/o having DEBUGF configured.

Agreed, especially about making it optional and depend upon DEBUGFS.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html