netdev - Re: [PATCH net-next] lwtunnel: rename ip lwtunnel attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Aug 2015 18:51:07 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	netdev@...r.kernel.org, Roopa Prabhu <roopa@...ulusnetworks.com>
Subject: Re: [PATCH net-next] lwtunnel: rename ip lwtunnel attributes

On 08/14/15 at 04:40pm, Jiri Benc wrote:
> We already have IFLA_IPTUN_ netlink attributes. The IP_TUN_ attributes look
> very similar, yet they serve very different purpose. This is confusing for
> anyone trying to implement a user space tool supporting lwt.
> 
> As the IP_TUN_ attributes are used only for the lightweight tunnels, prefix
> them with LWTUNNEL_IP_ instead to make their purpose clear. Also, it's more
> logical to have them in lwtunnel.h together with the encap enum.
> 
> Fixes: 3093fbe7ff4b ("route: Per route IP tunnel metadata via lightweight tunnel")
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Acked-by: Thomas Graf <tgraf@...g.ch>

> ---
> These are still in net-next only, thus it's safe to change them.
> 
> It's still a bit weird these attributes are in RTA_ENCAP, perhaps we should
> also rename RTA_ENCAP to RTA_LWT_ENCAP or similar?

I think RTA_ENCAP is fine but I don't mind changing it either.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html