netdev - Re: [PATCH net-next v3] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 18 Aug 2015 20:24:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	netdev@...r.kernel.org, dsa@...ulusnetworks.com,
	shm@...ulusnetworks.com, nikolay@...ulusnetworks.com
Subject: Re: [PATCH net-next v3] vrf: vrf_master_ifindex_rcu is not always
 called with rcu read lock

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Tue, 18 Aug 2015 21:40:16 +0300

> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> While running net-next I hit this:
 ...
> It would seem vrf_master_ifindex_rcu() can be called without RCU held in
> other contexts as well so introduce a new helper which acquires rcu and
> returns the ifindex.
> Also add curly braces around both the "if" and "else" parts as per the
> style guide.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
> v3: keep the rcu comment above vrf_master_ifindex_rcu()
> v2: use a new helper that acquires and releases rcu instead

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html