lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Aug 2015 06:11:12 +0000 From: "Izumi, Taku" <izumi.taku@...fujitsu.com> To: David Miller <davem@...emloft.net> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>, "dvhart@...radead.org" <dvhart@...radead.org>, "rkhan@...hat.com" <rkhan@...hat.com>, "alexander.h.duyck@...hat.com" <alexander.h.duyck@...hat.com>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, "joe@...ches.com" <joe@...ches.com>, "sergei.shtylyov@...entembedded.com" <sergei.shtylyov@...entembedded.com>, "stephen@...workplumber.org" <stephen@...workplumber.org>, "yasu.isimatu@...il.com" <yasu.isimatu@...il.com> Subject: RE: [PATCH v2.2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver Dear David, Thank you for reviewing. I'll update patchset according to your comment. Sincerely, Taku Izumi > -----Original Message----- > From: David Miller [mailto:davem@...emloft.net] > Sent: Friday, August 21, 2015 7:49 AM > To: Izumi, Taku/泉 拓 > Cc: netdev@...r.kernel.org; platform-driver-x86@...r.kernel.org; dvhart@...radead.org; rkhan@...hat.com; > alexander.h.duyck@...hat.com; linux-acpi@...r.kernel.org; joe@...ches.com; sergei.shtylyov@...entembedded.com; > stephen@...workplumber.org; yasu.isimatu@...il.com > Subject: Re: [PATCH v2.2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver > > From: Taku Izumi <izumi.taku@...fujitsu.com> > Date: Thu, 20 Aug 2015 17:46:05 +0900 > > > +obj-$(CONFIG_FUJITSU_ES) += fjes.o > > + > > +fjes-objs := fjes_main.o > > + > > Please do not have trailing empty lines in any files you add > or edit, 'git' warns about this even when applying patches. > > > +static int fjes_acpi_add(struct acpi_device *device) > > +{ > > + acpi_status status; > > + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL}; > > + union acpi_object *str; > > + char str_buf[sizeof(FJES_ACPI_SYMBOL) + 1]; > > + int result; > > + struct platform_device *plat_dev; > > Please order your local variables in "reverse christmas tree" order, which > means longer lines come before shorter ones. > > Please correct this problem in your entire submission, as I am not going > to point out each and every other place where this problem exists. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists