netdev - Re: [PATCH v2 net-next] r8169: Add values missing in @get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Aug 2015 01:59:40 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Corinna Vinschen <vinschen@...hat.com>
Cc:	netdev@...r.kernel.org, Hayes Wang <hayeswang@...ltek.com>,
	Ivan Vecera <ivecera@...hat.com>,
	David Miller <davem@...emloft.net>,
	nic_swsd <nic_swsd@...ltek.com>
Subject: Re: [PATCH v2 net-next] r8169: Add values missing in @get_stats64
 from HW counters

Corinna Vinschen <vinschen@...hat.com> :
> On Aug 21 21:39, Francois Romieu wrote:
[...]
> > The code should propagate failure when both rtl8169_reset_counters and
> > rtl8169_update_counters fail.
> 
> This one I don't understand.  Neither failing to reset the counters nor
> failing to update the counters is fatal for the driver.  So far the
> (unchanged) rtl8169_update_counters doesn't even print a log message,

I wouldn't overestimate the value of log messages vs real status return.
Users can be quite unhappy with default settings that spam their logs
(it isn't a problem in open(), it's marginaly murphy plausible from
a periodic get_stats context).

The driver can't propagate errors from the current get_stats context
where rtl8169_update_counters is used. However it can be done in
open().

> while a failing reset in rtl8169_reset_counters now does.
> 
> Why is that not sufficent?

Because of the same reason(s) why this patch wants to improve things.

It isn't a showstopper.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html