netdev - Re: [PATCH net-next] net/mlx5e: Avoid accessing NULL pointer at ndo_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Aug 2015 13:45:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	achiad@...lanox.com
Cc:	netdev@...r.kernel.org, amirv@...lanox.com, ogerlitz@...lanox.com,
	saeedm@...lanox.com, talal@...lanox.com, ranas@...lanox.com
Subject: Re: [PATCH net-next] net/mlx5e: Avoid accessing NULL pointer at
 ndo_select_queue

From: Achiad Shochat <achiad@...lanox.com>
Date: Sun, 23 Aug 2015 16:12:14 +0300

> From: Rana Shahout <ranas@...lanox.com>
> 
> To avoid multiply/division operations on the data path,
> we hold a {channel, tc}==>txq mapping table.
> We held this mapping table inside the channel object that is
> being destroyed upon some configuration operations (e.g MTU change).
> So in case ndo_select_queue occurs during such a configuration operation,
> it may access a NULL channel pointer, resulting in kernel panic.
> To fix this issue we moved the {channel, tc}==>txq mapping table
> outside the channel object so that it will be available also
> during such configuration operations.
> 
> 
> Signed-off-by: Rana Shahout <ranas@...lanox.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html