netdev - Re: [PATCH v3 net-next 1/8] geneve: Initialize ethernet address in device setup.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2015 16:42:41 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 1/8] geneve: Initialize ethernet address in
 device setup.

On Mon, Aug 24, 2015 at 10:43:08AM -0700, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
> Reviewed-by: Jesse Gross <jesse@...ira.com>
> Acked-by: Thomas Graf <tgraf@...g.ch>
> ---
>  drivers/net/geneve.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index 897e1a3..95e9da0 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -297,6 +297,7 @@ static void geneve_setup(struct net_device *dev)
>  
>  	netif_keep_dst(dev);
>  	dev->priv_flags |= IFF_LIVE_ADDR_CHANGE | IFF_NO_QUEUE;
> +	eth_hw_addr_random(dev);
>  }
>  
>  static const struct nla_policy geneve_policy[IFLA_GENEVE_MAX + 1] = {
> @@ -364,9 +365,6 @@ static int geneve_newlink(struct net *net, struct net_device *dev,
>  			return -EBUSY;
>  	}
>  
> -	if (tb[IFLA_ADDRESS] == NULL)
> -		eth_hw_addr_random(dev);
> -
>  	err = register_netdevice(dev);
>  	if (err)
>  		return err;

Acked-by: John W. Linville <linville@...driver.com>

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html