netdev - Re: [PATCH -next v2 1/2] device property: Return -ENXIO if there is no suitable FW interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2015 16:25:59 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Steve Glendinning <steve.glendinning@...well.net>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Jeremy Linton <jeremy.linton@....com>, tony@...mide.com
Subject: Re: [PATCH -next v2 1/2] device property: Return -ENXIO if there
 is no suitable FW interface

On 08/26/2015 04:37 PM, Rafael J. Wysocki wrote:
> On Wednesday, August 26, 2015 01:20:44 PM Guenter Roeck wrote:
>> Return -ENXIO if device property array access functions don't find
>> a suitable firmware interface.
>>
>> This lets drivers decide if they should use available platform data
>> instead.
>>
>> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> ---
>> v2: Added patch
>>
>>   drivers/base/property.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/base/property.c b/drivers/base/property.c
>> index 287704d680bf..9600b824d138 100644
>> --- a/drivers/base/property.c
>> +++ b/drivers/base/property.c
>> @@ -69,6 +69,9 @@ static int pset_prop_read_array(struct property_set *pset, const char *name,
>>   	struct property_entry *prop;
>>   	unsigned int item_size;
>>
>> +	if (!pset)
>> +		return -ENXIO;
>> +
>
> This isn't exactly straightforward, because it relies on the fact that
> pset_prop_read_array() is the last thing tried by FWNODE_PROP_READ_ARRAY()
> and fwnode_property_read_string_array().  A comment about that might be
> helpful.
>
I see two options: Add a comment above, or change the calling code to

	...
	else if (is_pset(fwnode))
		return pset_prop_read_array(to_pset(fwnode), propname,
                          	            DEV_PROP_STRING, val, nval);
	return -ENXIO;

which would make it obvious and avoid side effects if the code is changed
later on. Would you be ok with this ?

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html