netdev - Re: [PATCH net-next] net: FIB tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Aug 2015 22:07:30 -0700
From:	David Ahern <dsa@...ulusnetworks.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: FIB tracepoints

On 8/27/15 10:05 PM, David Miller wrote:
> From: David Ahern <dsa@...ulusnetworks.com>
> Date: Thu, 27 Aug 2015 21:59:32 -0700
>
>> +		__array(	__u8,	src,	4	)
>> +		__array(	__u8,	dst,	4	)
>   ...
>> +		__array(	__u8,	src,	4	)
>
> Maybe there is something I don't understand about tracing, but why not
> use __u32?  If endianness types are the issue, just force cast it as
> needed.
>
> Using a memcpy() on a 4-byte array is kinda excessive.
>

Silly trick need to use %pI4. ie., printing the addresses as strings vs. 
hex.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html