netdev - Re: [PATCH net-next] net: Check frag_lists first to prevent data out of order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Aug 2015 13:34:13 +0800
From:	Weilong Chen <chenweilong@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<eric.dumazet@...il.com>, <edumazet@...gle.com>,
	<alexander.h.duyck@...hat.com>, <willemb@...gle.com>,
	<hannes@...essinduktion.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: Check frag_lists first to prevent data out
 of order

> From: Weilong Chen <chenweilong@...wei.com>
> Date: Fri, 28 Aug 2015 11:35:40 +0800
>
>> In my test, @to has a fraglist, but skb_tailroom(to) is not 0!
>> The test is about tipc, the function tipc_buf_append will merge 3 skbs
>> to one:
>> packet 1: len = 1420 skb_tailroom = 190
>> packet 2: len = 1420
>> 	packet 2 will be add to 1' fraglist, but not update skb_tailroom
>
> This operation is illegal.
>
> Once there are frags, tailroom is not permitted.
>
> .
>

Agree

Thanks

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html