netdev - Re: [PATCH] ethtool: Dump eeprom info for soldered on modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Sep 2015 10:52:25 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Ben Hutchings <bwh@...nel.org>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ethtool: Dump eeprom info for soldered on modules

On Sun, Aug 16, 2015 at 04:05:18AM +0200, Andrew Lunn wrote:
> Modules which are soldered onto the motherboard may also use the sff8079
> EEPROM format. Dump these in the same way as SFP modules.

Hi Ben

I posted this patch two weeks ago. Since this is my first ethtool
patch, i've no idea what your response time usually is. Do i need to
repost? Send a gentle reminder? Or just wait a bit longer?

Thanks
	Andrew

> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
>  sfpid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sfpid.c b/sfpid.c
> index b1a5044..0b5cd62 100644
> --- a/sfpid.c
> +++ b/sfpid.c
> @@ -401,7 +401,7 @@ static void sff8079_show_options(const __u8 *id)
>  void sff8079_show_all(const __u8 *id)
>  {
>  	sff8079_show_identifier(id);
> -	if ((id[0] == 0x03) && (id[1] == 0x04)) {
> +	if (((id[0] == 0x02) || (id[0] == 0x03)) && (id[1] == 0x04)) {
>  		sff8079_show_ext_identifier(id);
>  		sff8079_show_connector(id);
>  		sff8079_show_transceiver(id);
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html