lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Sep 2015 21:00:57 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: tgraf@...g.ch, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, fengguang.wu@...el.com, wfg@...ux.intel.com, lkp@...org Subject: Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads On Tue, Sep 01, 2015 at 02:46:48PM +0200, Phil Sutter wrote: > > This is not an inherent behaviour of the implementation but general > agreement. The insertion may fail non-permanently (returning -EBUSY), > users are expected to handle this by retrying the operation. Absolutely not. The only reason for an insertion to fail is if we can't allocate enough memory. Unless the user is also looping its kmalloc calls it definitely shouldn't be retrying the insert. If an expansion fails it means either that the system is suffering a catastrophic memory shortage, or the user of rhashtable is doing something wrong. Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists