lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 2 Sep 2015 14:01:53 +0000
From:	Paul Durrant <Paul.Durrant@...rix.com>
To:	Wei Liu <wei.liu2@...rix.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
	"Ian Campbell" <Ian.Campbell@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>
Subject: RE: [PATCH net-next] xen-netback: add support for multicast control

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@...rix.com]
> Sent: 02 September 2015 15:01
> To: Paul Durrant
> Cc: netdev@...r.kernel.org; xen-devel@...ts.xenproject.org; Ian Campbell;
> Wei Liu
> Subject: Re: [PATCH net-next] xen-netback: add support for multicast control
> 
> On Wed, Sep 02, 2015 at 01:19:53PM +0100, Paul Durrant wrote:
> > Xen's PV network protocol includes messages to add/remove ethernet
> > multicast addresses to/from a filter list in the backend. This allows
> > the frontend to request the backend only forward multicast packets
> > which are off interest thus preventing unnecessary noise on the shared
> 
> "of interest"

Ah yes :-)

> 
> > ring.
> >
> [...]
> > +
> > +void xenvif_mcast_flush(struct xenvif *vif)
> 
> Only one cosmetic comment.
> 
> My first impression of this function by looking at the name is that it
> flushes queued multicast packets. Maybe we can rename it to
> xenvif_mcast_addr_list_free ?
> 

Sure.

  Paul

> Wei.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists