lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Sep 2015 00:24:30 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Alexey Brodkin <Alexey.Brodkin@...opsys.com>, netdev@...r.kernel.org Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>, linux-kernel@...r.kernel.org, stable@...r.kernel.org, David Miller <davem@...emloft.net> Subject: Re: [PATCH v2] stmmac: fix check for phydev being open On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > Current implementation via IS_ERR(phydev) may make no sense because > of_phy_attach() returns NULL on failure instead of error value. Not of_phy_connect()? > Still for checking result of phy_connect() IS_ERR() is useful. > > To address both situations we use combined IS_ERR_OR_NULL() check. > > Cc: Giuseppe Cavallaro <peppe.cavallaro@...com> > Cc: linux-kernel@...r.kernel.org > Cc: stable@...r.kernel.org > Cc: David Miller <davem@...emloft.net> > Cc: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> > Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists