netdev - Re: [net-next PATCH v2] net: ipv6: use common fib_default_rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Sep 2015 13:45:37 +0200
From:	Phil Sutter <phil@....cc>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: [net-next PATCH v2] net: ipv6: use common fib_default_rule_pref

On Tue, Sep 08, 2015 at 10:38:09PM -0700, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Tue, 08 Sep 2015 22:37:05 -0700 (PDT)
> 
> > Applied, thanks.
> 
> Actually, reverted, this doesn't even compile.
> 
> net/core/fib_rules.c:47:12: error: static declaration of ‘fib_default_rule_pref’ follows non-static declaration
>  static u32 fib_default_rule_pref(struct fib_rules_ops *ops)
>             ^
> In file included from net/core/fib_rules.c:18:0:
> include/net/fib_rules.h:120:5: note: previous declaration of ‘fib_default_rule_pref’ was here
>  u32 fib_default_rule_pref(struct fib_rules_ops *ops);
>      ^

What the heck? I should throw away the optimizer, it seems to make me
skip testing sometimes. Sorry for the mess, I'll follow up with a fixed
and *tested* version.

Cheers, Phil
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html