netdev - Re: [PATCH net v2 1/1] net: fec: add netif status check before set mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 09 Sep 2015 20:30:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	b38611@...escale.com
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com,
	l.stach@...gutronix.de, f.fainelli@...il.com
Subject: Re: [PATCH net v2 1/1] net: fec: add netif status check before set
 mac address

From: Fugang Duan <b38611@...escale.com>
Date: Thu, 10 Sep 2015 09:35:39 +0800

> There exist one issue by below case that case system hang:
> ifconfig eth0 down
> ifconfig eth0 hw ether 00:10:19:19:81:19
> 
> After eth0 down, all fec clocks are gated off. In the .fec_set_mac_address()
> function, it will set new MAC address to registers, which causes system hang.
> 
> So it needs to add netif status check to avoid registers access when clocks are
> gated off. Until eth0 up the new MAC address are wrote into related registers.
> 
> V2:
> As Lucas Stach's suggestion, add a comment in the code to explain why it needed.
> 
> CC: Lucas Stach <l.stach@...gutronix.de>
> CC: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Fugang Duan <B38611@...escale.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html