netdev - Re: [PATCHv2 net] cxgb4vf: support for single-threading access to adapter mailbox registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Sep 2015 10:51:18 +0530
From:	Hariprasad S <hariprasad@...lsio.com>
To:	netdev@...r.kernel.org
Cc:	davem@...emloft.net, leedom@...lsio.com, nirranjan@...lsio.com
Subject: Re: [PATCHv2 net] cxgb4vf: support for single-threading access to
 adapter mailbox registers

On Mon, Sep 14, 2015 at 19:08:34 +0530, Hariprasad Shenai wrote:
> The issue is the for the Virtual Function Driver, the only way to get the
> Virtual Interface statistics is to issue mailbox commands to ask the
> firmware for the VI Stats. And, because the VI Stats command can only
> retrieve a smallish number of stats per mailbox command, we have to issue
> three mailbox commands in quick succession. What we ran into was irqbalance
> coming in every 10 seconds and interrogating every network interface in the
> system.
> 
> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>
> ---
> V2: Updated description and using linux completion API's instead of
>     for loop based on review comments by David Miller
> 
>  drivers/net/ethernet/chelsio/cxgb4vf/adapter.h     |  9 +++++
>  .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c    |  4 ++
>  drivers/net/ethernet/chelsio/cxgb4vf/t4vf_hw.c     | 46 +++++++++++++++++++++-
>  3 files changed, 58 insertions(+), 1 deletion(-)
> 


Hi David,

There is an issue with this patch. Can you please drop it.
Will send a V3, with the fixes. 

The below one should be a while loop, instead of if condition.
	/* If we're at the head, break out and start the mailbox
         * protocol.
         */
        if (list_first_entry(&adapter->mlist.list,
                             struct mbox_list, list) != &entry) {
                int ret;

Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html