netdev - Re: [PATCH next 0/30] Passing net through the netfilter hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Sep 2015 17:24:37 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	nicolas.dichtel@...nd.com
Cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	David Miller <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH next 0/30] Passing net through the netfilter hooks

Nicolas Dichtel <nicolas.dichtel@...nd.com> writes:

> Le 16/09/2015 02:59, Eric W. Biederman a écrit :
>>
>> My primary goal with this patchset and it's follow ups is to cleanup the
>> network routing paths so that we do not look at the output device to
>> derive the network namespace.  My plan is to pass the network namespace
>> of the transmitting socket through the output path, to replace code that
>> looks at the output network device today.  Once that is done we can have
>> routes with output devices outside of the current network namespace.
>> Which should allow reception and transmission of packets in network
>> namespaces to be as fast as normal packet reception and transmission
>> with early demux disabled, because it will same code path.
>>
>> Once skb_dst(skb)->dev is a little better under control I think it will
>> also be possible to use rcu to cleanup the ancient hack that sets
>> dst->dev to loopback_dev when a network device is removed.
>>
>> The work to get there is a series of code cleanups.  I am starting with
>> passing net into the netfilter hooks and into the functions that are
>> called after the netfilter hooks.  This removes from netfilter the
>> need to guess which network namespace it is working on.
>>
>> To get there I perform a series of minor prep patches so the big changes
>> at the end are possible to audit without getting lost in the noise.  In
>> particular I have a lot of patches computing net into a local variable
>> and then using it through out the function.
>>
>> So this patchset encompases removing dead code, sorting out the _sk
>> functions that were added last time someone pushed a prototype change
>> through the post netfilter functions.  Cleaning up individual functions
>> use of the network namespace.  Passing net into the netfilter hooks.
>> Passing net into the post netfilter functions.  Using state->net in
>> the netfilter code where it is available and trivially usable.
> LGTM (except some minor comments).
>
> Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Thanks for review.  I have added an extra patch for the missing blank
lines that are still missing after the entire series.  As they affect
neither code correctness nor bisectability I don't think there is any
point respinning the indivdual patches.

Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html