netdev - RE: [RFC v2 net-next 05/10] qede: Add basic network device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Sep 2015 06:02:39 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	David Miller <davem@...emloft.net>
CC:	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	netdev <netdev@...r.kernel.org>,
	Ariel Elior <Ariel.Elior@...gic.com>,
	"Sudarsana Kalluru" <Sudarsana.Kalluru@...gic.com>
Subject: RE: [RFC v2 net-next 05/10] qede: Add basic network device support

> >> > +struct qede_rx_queue {
> >> > +	__le16			*hw_cons_ptr;
> >>
> >> The __ variants of constants should be reserved for use in user
> >> visible API's
> >
> > Really? If so, this needs to be fixed not only here but in lots of
> > places in the series [e.g., entire HW HSI uses __le variants instead of le].
> > But why is it so? I.e., I understand that __le16 is defined in the
> > uapi directory and thus accessible to users, but why the distinction?
> 
> Because it shows whether the type is something exposed to userspace or not.
> 
> If there are places where this is done incorrectly in the tree, it is not a legitimate
> reason for you to do so as well.

Obviously.
We'll fix all of those for next version.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html