lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 26 Sep 2015 22:38:55 -0700 (PDT) From: David Miller <davem@...emloft.net> To: dwmw2@...radead.org Cc: romieu@...zoreil.com, netdev@...r.kernel.org Subject: Re: [PATCH v2 RFC] 8139cp: Fix GSO MSS handling From: David Woodhouse <dwmw2@...radead.org> Date: Thu, 24 Sep 2015 11:38:22 +0100 > When fixing the TSO support I noticed we just mask ->gso_size with the > MSSMask value and don't care about the consequences. > > Provide a .ndo_features_check() method which drops the NETIF_F_TSO > feature for any skb which would exceed the maximum, and thus forces it > to be segmented by software. > > Then we can stop the masking in cp_start_xmit(), and just WARN if the > maximum is exceeded, which should now never happen. > > Finally, Francois Romieu noticed that we didn't even have the right > value for MSSMask anyway; it should be 0x7ff (11 bits) not 0xfff. > > Signed-off-by: David Woodhouse <David.Woodhouse@...el.com> I'm going to apply this to net-next, thanks David. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists