lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 27 Sep 2015 07:31:39 +0300 From: Or Gerlitz <gerlitz.or@...il.com> To: Robb Manes <rmanes@...hat.com> Cc: netdev <netdev@...r.kernel.org>, Amir Vadai <amirv@...lanox.com>, Eugenia Emantayev <eugenia@...lanox.com> Subject: Re: [PATCH] net/mlx4: Handle return codes in mlx4_qp_attach_common On Fri, Sep 25, 2015 at 5:39 PM, Robb Manes <rmanes@...hat.com> wrote: > Both new_steering_entry() and existing_steering_entry() return values > based on their success or failure, but currently they fall through > silently. This can make troubleshooting difficult, as we were unable > to tell which one of these two functions returned errors or > specifically what code was returned. This patch remedies that > situation by passing the return codes to err, which is returned by > mlx4_qp_attach_common() itself. > > This also addresses a leak in the call to mlx4_bitmap_free() as well. > > Signed-off-by: Robb Manes <rmanes@...hat.com> looks correct. Acked-by: Or Gerlitz <ogerlitz@...lanox.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists