lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Sep 2015 15:52:46 +0200 From: Andrzej Pietrasiewicz <andrzej.p@...sung.com> To: Christoph Hellwig <hch@....de> Cc: Joel Becker <jlbec@...lplan.org>, Andrew Morton <akpm@...ux-foundation.org>, Felipe Balbi <balbi@...com>, Tejun Heo <tj@...nel.org>, Pratyush Anand <pratyush.anand@...il.com>, target-devel@...r.kernel.org, cluster-devel@...hat.com, ocfs2-devel@....oracle.com, linux-usb@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 07/23] usb-gadget/f_loopback: use per-attribute show and store methods Hi, W dniu 28.09.2015 o 15:41, Christoph Hellwig pisze: > On Mon, Sep 28, 2015 at 01:46:57PM +0200, Andrzej Pietrasiewicz wrote: >>> } >>> >>> -static struct f_lb_opts_attribute f_lb_opts_qlen = >>> - __CONFIGFS_ATTR(qlen, S_IRUGO | S_IWUSR, >>> - f_lb_opts_qlen_show, >>> - f_lb_opts_qlen_store); >>> - >> In my opinion the below line belongs here: >> >> +CONFIGFS_ATTR(f_lb_opts_, qlen); > > The idea is to keep all the attribute defintions near the attribute > array, similar to how most drivers define their sysfs attributes. > You were not consistent with the approach, though: with some patches CONFIGFS_ATTR() are where __CONFIGFS_ATTR were, with some other they are grouped. > If you really don't like that way I'll move it back. I think the change is more explicit/readable if the macro invocations are where what they substitute used to be. AP -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists