netdev - Re: [PATCH] net ipv4: use preferred log methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Sep 2015 17:31:27 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Bastian Stender <bst@...gutronix.de>
Cc:	kbuild-all@...org, "David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	trivial@...nel.org, kernel@...gutronix.de,
	Bastian Stender <bst@...gutronix.de>
Subject: Re: [PATCH] net ipv4: use preferred log methods

Hi Bastian,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: mips-jz4740 (attached as .config)
reproduce:
  wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
  chmod +x ~/bin/make.cross
  git checkout 5b4b43e3d9b6dcebef0324965111b8e5a8bcd6e8
  # save the attached .config to linux build tree
  make.cross ARCH=mips 

All error/warnings (new ones prefixed by >>):

   net/ipv4/ipconfig.c: In function 'ic_open_devs':
>> net/ipv4/ipconfig.c:244:4: error: implicit declaration of function 'DBG' [-Werror=implicit-function-declaration]
       DBG(("IP-Config: %s UP (able=%d, xid=%08x)\n",
       ^
>> net/ipv4/ipconfig.c:244:49: warning: left-hand operand of comma expression has no effect [-Wunused-value]
       DBG(("IP-Config: %s UP (able=%d, xid=%08x)\n",
                                                    ^
   net/ipv4/ipconfig.c:245:14: warning: left-hand operand of comma expression has no effect [-Wunused-value]
        dev->name, able, d->xid));
                 ^
   net/ipv4/ipconfig.c:245:20: warning: left-hand operand of comma expression has no effect [-Wunused-value]
        dev->name, able, d->xid));
                       ^
   net/ipv4/ipconfig.c: In function 'ic_close_devs':
   net/ipv4/ipconfig.c:301:34: warning: left-hand operand of comma expression has no effect [-Wunused-value]
       DBG(("IP-Config: Downing %s\n", dev->name));
                                     ^
   net/ipv4/ipconfig.c: In function 'ip_auto_config_setup':
   net/ipv4/ipconfig.c:1602:43: warning: left-hand operand of comma expression has no effect [-Wunused-value]
       DBG(("IP-Config: Parameter #%d: `%s'\n", num, ip));
                                              ^
   net/ipv4/ipconfig.c:1602:48: warning: left-hand operand of comma expression has no effect [-Wunused-value]
       DBG(("IP-Config: Parameter #%d: `%s'\n", num, ip));
                                                   ^
   cc1: some warnings being treated as errors

vim +/DBG +244 net/ipv4/ipconfig.c

^1da177e Linus Torvalds 2005-04-16  238  			d->able = able;
^1da177e Linus Torvalds 2005-04-16  239  			if (able & IC_BOOTP)
5a874db4 Al Viro        2006-11-08  240  				get_random_bytes(&d->xid, sizeof(__be32));
^1da177e Linus Torvalds 2005-04-16  241  			else
^1da177e Linus Torvalds 2005-04-16  242  				d->xid = 0;
^1da177e Linus Torvalds 2005-04-16  243  			ic_proto_have_if |= able;
^1da177e Linus Torvalds 2005-04-16 @244  			DBG(("IP-Config: %s UP (able=%d, xid=%08x)\n",
^1da177e Linus Torvalds 2005-04-16  245  				dev->name, able, d->xid));
^1da177e Linus Torvalds 2005-04-16  246  		}
^1da177e Linus Torvalds 2005-04-16  247  	}

:::::: The code at line 244 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (17582 bytes)