netdev - Re: [PATCH] net/unix: fix logic about sk_peek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 3 Oct 2015 22:48:05 +0300
From:	Andrey Vagin <avagin@...nvz.org>
To:	Aaron Conole <aconole@...heb.org>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH] net/unix: fix logic about sk_peek_offset

2015-10-02 15:17 GMT+03:00 Aaron Conole <aconole@...heb.org>:
> Andrey Vagin <avagin@...nvz.org> writes:
>
>> 2015-10-02 0:05 GMT+03:00 Andrey Vagin <avagin@...il.com>:
>>> From: Andrey Vagin <avagin@...nvz.org>
>>>
>>> Now send with MSG_PEEK can return data from multiple SKBs.
>>>
>>> Unfortunately we take into account the peek offset for each skb,
>>> that is wrong. We need to apply the peek offset only once.
>>>
>>> In addition, the peek offset should be used only if MSG_PEEK is set.
> <<snip>>
> Agreed here, the behavior is off in the peek offset case.
>
> I was unable to apply your patch, for some reason, but will manually
> try to apply it and test.

It's strange. I've checked that this patch can be applied to
davem/net.git and next/linux-next.git,

[avagin@...top linux-next]$ git checkout net/master
HEAD is now at 36f8daf... Merge tag 'mmc-v4.3-rc3' of
git://git.linaro.org/people/ulf.hansson/mmc
[avagin@...top linux-next]$ wget https://patchwork.ozlabs.org/patch/525310/mbox/
--2015-10-03 22:46:44--  https://patchwork.ozlabs.org/patch/525310/mbox/
Resolving patchwork.ozlabs.org (patchwork.ozlabs.org)...
103.22.144.67, 2401:3900:2:1::2
Connecting to patchwork.ozlabs.org
(patchwork.ozlabs.org)|103.22.144.67|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/plain]
Saving to: ‘index.html’

index.html                                  [ <=>
                                                      ]   2.06K
--.-KB/s   in 0s

2015-10-03 22:46:47 (122 MB/s) - ‘index.html’ saved [2106]

[avagin@...top linux-next]$ git am index.html
Applying: net/unix: fix logic about sk_peek_offset

>
> Thanks very much!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html