netdev - Re: [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 4 Oct 2015 11:03:18 +0300
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	<clsoto@...ux.vnet.ibm.com>, <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <brking@...ux.vnet.ibm.com>,
	<amirv@...lanox.com>
Subject: Re: [PATCH net-next] net/mlx4_core: Test interrupts fail if not all
 comp vectors called request_irq

On 9/29/2015 9:38 PM, clsoto@...ux.vnet.ibm.com wrote:
> From: Carol L Soto <clsoto@...ux.vnet.ibm.com>
>
> Test interrupts fails if not all completion vectors called
> request_irq. This case can happen if only mlx4_en loads and
> we have more completion vectors than rx rings.

good catch! is this a bug since the driver 0-day or was introduced by
some recent commit? in the latercase, please add a Fixes: tag before 
your S.O.B note.
>
> Signed-off-by: Carol L Soto <clsoto@...ux.vnet.ibm.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/eq.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
> index 8e81e53..c344884 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/eq.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
> @@ -1364,6 +1364,10 @@ int mlx4_test_interrupts(struct mlx4_dev *dev)
>   	 * and performing a NOP command
>   	 */
>   	for(i = 0; !err && (i < dev->caps.num_comp_vectors); ++i) {
> +		/* Make sure request_irq was called */
> +		if (!priv->eq_table.eq[i].have_irq)
> +			continue;
> +
>   		/* Temporary use polling for command completions */
>   		mlx4_cmd_use_polling(dev);
>   

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html