lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 05 Oct 2015 23:35:37 -0700 (PDT) From: David Miller <davem@...emloft.net> To: cwang@...pensource.com Cc: dsa@...ulusnetworks.com, netdev@...r.kernel.org, dsahern@...il.com Subject: Re: [PATCH net-next v2] net: Fix unused variable compile warning From: Cong Wang <cwang@...pensource.com> Date: Mon, 5 Oct 2015 10:53:57 -0700 > On Thu, Oct 1, 2015 at 8:49 AM, David Ahern <dsa@...ulusnetworks.com> wrote: >> Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if >> CONFIG_IP_VS_IPV6 is not enabled: >> >> ../net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_out’: >> ../net/netfilter/ipvs/ip_vs_core.c:1177:14: warning: unused variable ‘net’ [-Wunused-variable] >> >> After the net refactoring there is only 1 user; push the reference to the >> 1 user. While the line length slightly exceeds 80 it seems to be the >> best change. >> >> Fixes: 1b75097dd7a26("ipvs: Pass ipvs into ip_vs_out") >> Signed-off-by: David Ahern <dsa@...ulusnetworks.com> > > I saw the same build warning, and this fix looks good to me. > > DaveM, can you take this? It should be submitted to netfilter-devel and Pablo should take it.
Powered by blists - more mailing lists