lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 Oct 2015 10:02:40 +0900 From: Simon Horman <horms@...ge.net.au> To: David Miller <davem@...emloft.net> Cc: cwang@...pensource.com, dsa@...ulusnetworks.com, netdev@...r.kernel.org, dsahern@...il.com Subject: Re: [PATCH net-next v2] net: Fix unused variable compile warning On Mon, Oct 05, 2015 at 11:35:37PM -0700, David Miller wrote: > From: Cong Wang <cwang@...pensource.com> > Date: Mon, 5 Oct 2015 10:53:57 -0700 > > > On Thu, Oct 1, 2015 at 8:49 AM, David Ahern <dsa@...ulusnetworks.com> wrote: > >> Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if > >> CONFIG_IP_VS_IPV6 is not enabled: > >> > >> ../net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_out’: > >> ../net/netfilter/ipvs/ip_vs_core.c:1177:14: warning: unused variable ‘net’ [-Wunused-variable] > >> > >> After the net refactoring there is only 1 user; push the reference to the > >> 1 user. While the line length slightly exceeds 80 it seems to be the > >> best change. > >> > >> Fixes: 1b75097dd7a26("ipvs: Pass ipvs into ip_vs_out") > >> Signed-off-by: David Ahern <dsa@...ulusnetworks.com> > > > > I saw the same build warning, and this fix looks good to me. > > > > DaveM, can you take this? > > It should be submitted to netfilter-devel and Pablo should take it. lvs-devel would be better yet. I submitted an identical patch there yesterday. I'll pick up David's version and send it to Pablo ASAP. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists