netdev - Re: [net-next 07/18] i40e: make i40e_init_pf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 8 Oct 2015 21:53:02 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:	Shannon Nelson <shannon.nelson@...el.com>, netdev@...r.kernel.org,
	nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 07/18] i40e: make i40e_init_pf_fcoe to void

Hello.

On 10/08/2015 01:47 AM, Jeff Kirsher wrote:

> From: Shannon Nelson <shannon.nelson@...el.com>
>
> i40e_init_pf_fcoe() didn't return anything except 0, it prints enough
> error info already, and no driver logic depends on the return value,
> so this can be void.
>
> Change-ID: Ie6afad849857d87a7064c42c3cce14c74c2f29d8
> Signed-off-by: Shannon Nelson <shannon.nelson@...el.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
[...]

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> index 5ea75dd..2398d9b 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
[...]
> @@ -326,7 +324,7 @@ int i40e_init_pf_fcoe(struct i40e_pf *pf)
>   	wr32(hw, I40E_GLFCOE_RCTL, val);
>
>   	dev_info(&pf->pdev->dev, "FCoE is supported.\n");
> -	return 0;
> +	return;

    Not needed at all.

>   }
>
>   /**
[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html