lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 08 Oct 2015 14:11:41 +0200 From: Arnd Bergmann <arnd@...db.de> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, aconole@...heb.org, edumazet@...gle.com, james.l.morris@...cle.com, linux-security-module@...r.kernel.org, serge@...lyn.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] af_unix: introduce unix_sk_const helper On Thursday 08 October 2015 04:03:32 David Miller wrote: > From: Arnd Bergmann <arnd@...db.de> > Date: Tue, 06 Oct 2015 22:52:46 +0200 > > > Commit 124613012db1 ("af_unix: Convert the unix_sk macro to an inline > > function for type safety") was recently added to catch incorrect > > uses of the unix_sk helper using compiler warnings. > > > > It has now caught one such case in lsm_audit.c. The code is technically > > correct, but as it converts a const pointer to a non-const pointer, > > the annotation got lost, which gcc now warns about. > > > > This patch avoids the warning by introducing an additional helper > > that has const input and output, which makes the lsm_audit code build > > cleanly again. > > > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > > --- > > I'm not entirely happy with this workaround myself, but could not come > > up with a better one. > > You can make the argument unconditionally const, as Paul Moore has done > in a separate patch submission. Ok, I see now how Paul's "audit: constify parts of common_audit_data and lsm_network_audit" patch caused the problem and is now gone from linux-next. That seems nicer indeed. Arnd -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists