netdev - [PATCH] bnxt_en: fix returnvar.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Oct 2015 20:24:22 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Michael Chan <mchan@...adcom.com>
Cc:	kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org
Subject: [PATCH] bnxt_en: fix returnvar.cocci warnings

drivers/net/ethernet/broadcom/bnxt/bnxt.c:1290:5-7: Unneeded variable: "rc". Return "0" on line 1304


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: Michael Chan <mchan@...adcom.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

Please take the patch only if it's a positive warning. Thanks!

 bnxt.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -1287,7 +1287,6 @@ next_rx_no_prod:
 static int bnxt_async_event_process(struct bnxt *bp,
 				    struct hwrm_async_event_cmpl *cmpl)
 {
-	int rc = 0;
 	u16 event_id = le16_to_cpu(cmpl->event_id);
 
 	/* TODO CHIMP_FW: Define event id's for link change, error etc */
@@ -1301,7 +1300,7 @@ static int bnxt_async_event_process(stru
 			   event_id);
 		break;
 	}
-	return rc;
+	return 0;
 }
 
 static int bnxt_hwrm_handler(struct bnxt *bp, struct tx_cmp *txcmp)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html