netdev - Re: [PATCH net-next v5 01/10] qed: Add module with basic common support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2015 23:54:29 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>
Cc:	netdev <netdev@...r.kernel.org>,
	Ariel Elior <Ariel.Elior@...gic.com>
Subject: Re: [PATCH net-next v5 01/10] qed: Add module with basic common
 support

Yuval Mintz <Yuval.Mintz@...gic.com> :
[...]
> > > +struct qed_simd_fp_handler {
> > > +     void    *token;
> > > +     void    (*func)(void *);
> > > +};
> > Use union * ?
> The token is a cookie to be used by a func, so union isn't appropriate.

Lets' reformulate: replace 'void * token' by 'union foobar *token'.

void * silents compiler. union * doesn't.

[...]
> > > +             rc = -ENOMEM;
> > > +             goto ilt_shadow_fail;
> > > +     } else {
> > > +             DP_VERBOSE(p_hwfn, QED_MSG_ILT,
> > > +                        "Allocated 0x%x bytes for ilt shadow\n",
> > > +                        (u32)(size * sizeof(struct qed_dma_mem)));
> > > +     }
> > The "else" branch after the "goto" isn't idiomatic.
> Not that I mind, but is such a prefernce described in any style-guide?

Documentation/CodingStyle gives some hints in its "goto" section but it
doesn't specifically go that far. Is there a reward if I can exhumate
some message on netdev where it would had already been outlined ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html