lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Oct 2015 06:02:03 -0700 (PDT) From: David Miller <davem@...emloft.net> To: pabeni@...hat.com Cc: netdev@...r.kernel.org, corbet@....net, kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net Subject: Re: [PATCH net-next] Revert "ipv4/icmp: redirect messages can use the ingress daddr as source" From: Paolo Abeni <pabeni@...hat.com> Date: Wed, 14 Oct 2015 14:25:53 +0200 > Revert the commit e2ca690b657f ("ipv4/icmp: redirect messages > can use the ingress daddr as source"), which tried to introduce a more > suitable behaviour for ICMP redirect messages generated by VRRP routers. > However RFC 5798 section 8.1.1 states: > > The IPv4 source address of an ICMP redirect should be the address > that the end-host used when making its next-hop routing decision. > > while said commit used the generating packet destination > address, which do not match the above and in most cases leads to > no redirect packets to be generated. > > Signed-off-by: Paolo Abeni <pabeni@...hat.com> Applied, thanks. I honestly still didn't like the change at all, but begrudgedly applied it hoping to avoid people saying crap like "Linux refuses to support VRRP"... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists