netdev - Re: [PATCH net-next v6 01/10] qed: Add module with basic common support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 Oct 2015 18:52:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Yuval.Mintz@...gic.com
Cc:	netdev@...r.kernel.org, Ariel.Elior@...gic.com
Subject: Re: [PATCH net-next v6 01/10] qed: Add module with basic common
 support

From: Yuval Mintz <Yuval.Mintz@...gic.com>
Date: Wed, 14 Oct 2015 09:24:05 +0300

> +int qed_qm_pf_rt_init(struct qed_hwfn			*p_hwfn,
> +		      struct qed_ptt			*p_ptt,
> +		      u8				port_id,
> +		      u8				pf_id,
> +		      u8				max_phys_tcs_per_port,
> +		      bool				is_first_pf,
> +		      u32				num_pf_cids,
> +		      u32				num_vf_cids,
> +		      u32				num_tids,
> +		      u16				start_pq,
> +		      u16				num_pf_pqs,
> +		      u16				num_vf_pqs,
> +		      u8				start_vport,
> +		      u8				num_vports,
> +		      u8				pf_wfq,
> +		      u32				pf_rl,
> +		      struct init_qm_pq_params		*pq_params,
> +		      struct init_qm_vport_params	*vport_params);

Sorry, this is completely rediculous.

No function should have so many parameters.

If you need to pass this much information to a function, create a structure in
which to contain the values and pass a reference to that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html