netdev - Re: [PATCH net 1/3] openvswitch: Reject ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Oct 2015 11:09:47 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Joe Stringer <joestringer@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net 1/3] openvswitch: Reject ct_state masks for unknown bits

On Wed, Oct 14, 2015 at 11:10 AM, Joe Stringer <joestringer@...ira.com> wrote:
> Currently, 0-bits are generated in ct_state where the bit position is
> undefined, and matches are accepted on these bit-positions. If userspace
> requests to match the 0-value for this bit then it may expect only a
> subset of traffic to match this value, whereas currently all packets
> will have this bit set to 0. Fix this by rejecting such masks.
>
> Signed-off-by: Joe Stringer <joestringer@...ira.com>
> ---
>  net/openvswitch/conntrack.h    | 11 +++++------
>  net/openvswitch/flow_netlink.c |  5 ++++-
>  2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/net/openvswitch/conntrack.h b/net/openvswitch/conntrack.h
> index da8714942c95..2d42b3640117 100644
> --- a/net/openvswitch/conntrack.h
> +++ b/net/openvswitch/conntrack.h
> @@ -35,12 +35,9 @@ void ovs_ct_fill_key(const struct sk_buff *skb, struct sw_flow_key *key);
>  int ovs_ct_put_key(const struct sw_flow_key *key, struct sk_buff *skb);
>  void ovs_ct_free_action(const struct nlattr *a);
>
> -static inline bool ovs_ct_state_supported(u32 state)
> -{
> -       return !(state & ~(OVS_CS_F_NEW | OVS_CS_F_ESTABLISHED |
> -                        OVS_CS_F_RELATED | OVS_CS_F_REPLY_DIR |
> -                        OVS_CS_F_INVALID | OVS_CS_F_TRACKED));
> -}
Can you also remove definition of ovs_ct_state_supported() in case
where conntrack is not enabled.

Otherwise looks good.

Acked-by: Pravin B Shelar <pshelar@...ira.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html