netdev - RE: [PATCH net-next v2] netlink: Rightsize IFLA_AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Oct 2015 05:52:40 +0000
From:	"Arad, Ronen" <ronen.arad@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size
 calculation



>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net]
>Sent: Wednesday, October 14, 2015 7:24 PM
>To: Arad, Ronen
>Cc: netdev@...r.kernel.org
>Subject: Re: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size
>calculation
>
>From: Ronen Arad <ronen.arad@...el.com>
>Date: Wed, 14 Oct 2015 08:51:28 -0700
>
>> @@ -900,7 +901,7 @@ static noinline size_t if_nlmsg_size(const struct
>net_device *dev,
>>  	       + rtnl_vfinfo_size(dev, ext_filter_mask) /* IFLA_VFINFO_LIST */
>>  	       + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS +
>IFLA_PORT_SELF */
>>  	       + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
>> -	       + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
>> +		+ rtnl_link_get_af_size(dev, ext_filter_mask) /* IFLA_AF_SPEC */
>>  	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN) /* IFLA_PHYS_PORT_ID */
>
>Please don't change the indentation on this line, keep it matching
>the indentation of all of the surrounding lines of this expression.
[@Ronen] Sure. V3 submitted. My editor didn't like the indentation of the
surrounding lines which are one less than two TAB spaces but consistency
is important. 
>
>Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html