netdev - Re: [PATCH V4 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Oct 2015 19:14:05 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Kaixu Xia <xiakaixu@...wei.com>, davem@...emloft.net,
	acme@...nel.org, mingo@...hat.com, a.p.zijlstra@...llo.nl,
	masami.hiramatsu.pt@...achi.com, jolsa@...nel.org,
	daniel@...earbox.net
Cc:	wangnan0@...wei.com, linux-kernel@...r.kernel.org,
	pi3orama@....com, hekuang@...wei.com, netdev@...r.kernel.org
Subject: Re: [PATCH V4 1/1] bpf: control events stored in PERF_EVENT_ARRAY
 maps trace data output when perf sampling

On 10/19/15 3:37 AM, Kaixu Xia wrote:
> +/* flags for PERF_EVENT_ARRAY maps*/
> +enum {
> +	BPF_EVENT_CTL_BIT_CUR = 0,
> +	BPF_EVENT_CTL_BIT_ALL = 1,
> +	__NR_BPF_EVENT_CTL_BITS,
> +};
> +
> +#define	BPF_CTL_BIT_FLAG_MASK \
> +	((1ULL << __NR_BPF_EVENT_CTL_BITS) - 1)
> +#define	BPF_CTL_BIT_DUMP_CUR \
> +	(1ULL << BPF_EVENT_CTL_BIT_CUR)
> +#define	BPF_CTL_BIT_DUMP_ALL \
> +	(1ULL << BPF_EVENT_CTL_BIT_ALL)
> +

the above shouldn't be part of uapi header. It can stay in bpf_trace.c
Just document these bits next to helper similar to skb_store_bytes()

The rest looks ok.
It still needs an ack from Peter for perf_event bits

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html