netdev - Re: [PATCH net-next] ipvlan: read direct ifindex instead of iflink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Oct 2015 06:39:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bblanco@...mgrid.com
Cc:	netdev@...r.kernel.org, maheshb@...gle.com
Subject: Re: [PATCH net-next] ipvlan: read direct ifindex instead of iflink

From: Brenden Blanco <bblanco@...mgrid.com>
Date: Tue, 20 Oct 2015 16:47:33 -0700

> In the ipv4 outbound path of an ipvlan device in l3 mode, the ifindex is
> being grabbed from dev_get_iflink. This works for the physical device
> case, since as the documentation of that function notes: "Physical
> interfaces have the same 'ifindex' and 'iflink' values.".  However, if
> the master device is a veth, and the pairs are in separate net
> namespaces, the route lookup will fail with -ENODEV due to outer veth
> pair being in a separate namespace from the ipvlan master/routing
> namespace.
> 
>   ns0    |   ns1    |   ns2
>  veth0a--|--veth0b--|--ipvl0
> 
> In ipvlan_process_v4_outbound(), a packet sent from ipvl0 in the above
> configuration will pass fl.flowi4_oif == veth0a to
> ip_route_output_flow(), but *net == ns1.
> 
> Notice also that ipv6 processing is not using iflink. Since there is a
> discrepancy in usage, fixup both v4 and v6 case to use local dev
> variable.
> 
> Tested this with l3 ipvlan on top of veth, as well as with single
> physical interface in the top namespace.
> 
> Signed-off-by: Brenden Blanco <bblanco@...mgrid.com>

Applied, thanks Brenden.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html