netdev - Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 22 Oct 2015 23:53:20 +0530
From:	punit vara <punitvara@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Kalle Valo <kvalo@....qualcomm.com>, stas.yakovlev@...il.com,
	chaoming_li@...lsil.com.cn,
	Larry Finger <Larry.Finger@...inger.net>,
	Christian Lamparter <chunkeey@...glemail.com>,
	sgruszka@...hat.com, brudley@...adcom.com, arend@...adcom.com,
	John Linville <linville@...driver.com>, jirislaby@...il.com,
	Nick Kossifidis <mickflemm@...il.com>, mcgrof@...not-panic.com,
	Eugene Krasnikov <k.eugene.e@...il.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	brcm80211-dev-list@...adcom.com, wcn36xx@...ts.infradead.org,
	"Berg, Johannes" <johannes.berg@...el.com>, meuleman@...adcom.com
Subject: Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret
 returning 0

On Thu, Oct 22, 2015 at 3:16 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> On 10/21/2015 05:55 PM, Punit Vara wrote:
>
>> This patch is to the ath5k/eeprom.c that fixes up warning caught by
>> coccicheck:
>>
>> Unneeded variable: "ret". Return "0" on line 980
>>
>> Remove unneeded variable ret created to return zero.
>>
>> Signed-off-by: Punit Vara <punitvara@...il.com>
>> ---
>>   drivers/net/wireless/ath/wcn36xx/main.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c
>> b/drivers/net/wireless/ath/wcn36xx/main.c
>> index 7c169ab..82982d5 100644
>> --- a/drivers/net/wireless/ath/wcn36xx/main.c
>> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
>> @@ -935,7 +935,6 @@ static const struct ieee80211_ops wcn36xx_ops = {
>>
>>   static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
>>   {
>> -       int ret = 0;
>>
>
>   This empty line should be removed too.
>
>>         static const u32 cipher_suites[] = {
>>                 WLAN_CIPHER_SUITE_WEP40,
>
> [...]
>
> MBR, Sergei
>
I have resend this patch as you said Sergei . Thanks for feedback ..
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html