netdev - Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Oct 2015 13:27:18 -0500
From:	Carol Soto <clsoto@...ux.vnet.ibm.com>
To:	Or Gerlitz <gerlitz.or@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>, brking@...ux.vnet.ibm.com,
	Jack Morgenstein <jackm@....mellanox.co.il>
Subject: Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof
 mlx4_eqe



On 10/26/2015 12:02 PM, Or Gerlitz wrote:
> On Mon, Oct 26, 2015 at 5:15 PM,  <clsoto@...ux.vnet.ibm.com> wrote:
>> From: Carol L Soto <clsoto@...ux.vnet.ibm.com>
>>
>> If the caps.eqe_size is bigger than the struct mlx4_eqe then there
>> is a potential for corrupting data at the master context. We can see
>> the message "Master failed to generate an EQE for slave: X" when the
>> event_eqe array wraps and we can see potential oops at the function
>> mlx4_GEN_EQE. Also correct a memset of cmd_eqe to use the sizeof
>> mlx4_eqe instead of eqe_size.
>>
>> Fixes: 08ff32352d6f ('mlx4: 64-byte CQE/EQE support')
>> Signed-off-by: Carol L Soto <clsoto@...ux.vnet.ibm.com>
> Thanks Carol, I'd like to review this a bit more tomorrow and will
> send it with another fix/es to net
Sure thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html