lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Oct 2015 10:50:11 -0400 From: Neal Cardwell <ncardwell@...gle.com> To: Bendik Rønning Opstad <bro.devel@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, James Morris <jmorris@...ei.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Patrick McHardy <kaber@...sh.net>, Jonathan Corbet <corbet@....net>, Eric Dumazet <edumazet@...gle.com>, Tom Herbert <tom@...bertland.com>, Yuchung Cheng <ycheng@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Erik Kline <ek@...gle.com>, Hannes Frederic Sowa <hannes@...essinduktion.org>, Al Viro <viro@...iv.linux.org.uk>, Jiri Pirko <jiri@...nulli.us>, Alexander Duyck <alexander.h.duyck@...hat.com>, Florian Westphal <fw@...len.de>, Daniel Lee <Longinus00@...il.com>, Marcelo Ricardo Leitner <mleitner@...hat.com>, Daniel Borkmann <daniel@...earbox.net>, Willem de Bruijn <willemb@...gle.com>, Linus Lüssing <linus.luessing@...3.blue>, linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Netdev <netdev@...r.kernel.org>, linux-api@...r.kernel.org, Andreas Petlund <apetlund@...ula.no>, Carsten Griwodz <griff@...ula.no>, Pål Halvorsen <paalh@...ula.no>, Jonas Markussen <jonassm@....uio.no>, Kristian Evensen <kristian.evensen@...il.com>, Kenneth Klette Jonassen <kennetkl@....uio.no>, Bendik Rønning Opstad <bro.devel+kernel@...il.com> Subject: Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB) On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad <bro.devel@...il.com> wrote: >@@ -2409,6 +2412,15 @@ static int do_tcp_setsockopt(struct sock *sk, int level, ... > + case TCP_RDB: > + if (val < 0 || val > 1) { > + err = -EINVAL; > + } else { > + tp->rdb = val; > + tp->nonagle = val; The semantics of the tp->nonagle bits are already a bit complex. My sense is that having a setsockopt of TCP_RDB transparently modify the nagle behavior is going to add more extra complexity and unanticipated behavior than is warranted given the slight possible gain in convenience to the app writer. What about a model where the application user just needs to remember to call setsockopt(TCP_NODELAY) if they want the TCP_RDB behavior to be sensible? I see your nice tests at https://github.com/bendikro/packetdrill/commit/9916b6c53e33dd04329d29b7d8baf703b2c2ac1b are already doing that. And my sense is that likewise most well-engineered "thin stream" apps will already be using setsockopt(TCP_NODELAY). Is that workable? neal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists