lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Oct 2015 22:05:14 -0700 (PDT) From: David Miller <davem@...emloft.net> To: masashi.honma@...il.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH] ipv6 route: Use flag instead of calling fib6_get_table() twice From: Masashi Honma <masashi.honma@...il.com> Date: Sun, 25 Oct 2015 11:44:27 +0900 > The fib6_get_table() is called twice to show the warning. > This patch reduces calling the function. > > Signed-off-by: Masashi Honma <masashi.honma@...il.com> I think the added cost of passing a reference to an on-stack variable exceeds the value of whatever you think you are improving here. The code as-is is fine as far as I'm concerned. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists