netdev - Re: [PATCH RFC 6/6] net/faraday: Enable offload checksum according to device-tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Nov 2015 11:36:10 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Gavin Shan <gwshan@...ux.vnet.ibm.com>, netdev@...r.kernel.org
Cc:	davem@...emloft.net, sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH RFC 6/6] net/faraday: Enable offload checksum according
 to device-tree

On Mon, 2015-11-09 at 11:10 +1100, Gavin Shan wrote:
> This enables IP/UDP/TCP offload checksum according to information
> passed on from bootloader through device-tree. The offload doesn't
> working properly when the interface works in NCSI mode.
> 
> Signed-off-by: Gavin Shan <gwshan@...ux.vnet.ibm.com>
> ---
>  drivers/net/ethernet/faraday/ftgmac100.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 1b13fd4..1e2f4d2 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -1377,7 +1377,10 @@ static int ftgmac100_probe(struct platform_device *pdev)
>  
>  > 	> netdev->ethtool_ops = &ftgmac100_ethtool_ops;
>  > 	> netdev->netdev_ops = &ftgmac100_netdev_ops;
> -> 	> netdev->features = NETIF_F_IP_CSUM | NETIF_F_GRO;
> +> 	> netdev->features = NETIF_F_GRO;
> +> 	> if (pdev->dev.of_node &&
> +> 	>     of_property_read_bool(pdev->dev.of_node, "no-hw-checksum"))
> +> 	> 	> netdev->features |= NETIF_F_IP_CSUM;

Am I reading properly that if you put "no-hw-checksum" in the device-
tree you *enable* HW checksum ? This doesn't look right to me...

The logic should be:

	if (pdev->dev.of_node &&
		of_property_read_bool(pdev->dev.of_node, "no-hw-checksum"))
		netdev->features &= ~NETIF_F_IP_CSUM;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html