lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Nov 2015 06:58:42 -0500 From: Peter Hurley <peter@...leysoftware.com> To: Johannes Stezenbach <js@...21.net> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, netdev@...r.kernel.org, Karsten Keil <isdn@...ux-pingi.de>, Martin Schwidefsky <schwidefsky@...ibm.com>, Heiko Carstens <heiko.carstens@...ibm.com>, Jesper Nilsson <jesper.nilsson@...s.com>, Mikael Starvik <starvik@...s.com>, Jiri Kosina <jikos@...nel.org>, David Sterba <dsterba@...e.com>, Mark Hounschell <markh@...pro.net> Subject: Re: [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior On 11/09/2015 04:12 AM, Johannes Stezenbach wrote: > On Sun, Nov 08, 2015 at 05:02:52PM -0500, Peter Hurley wrote: >> +void tty_ldisc_closing(struct tty_struct *tty) >> +{ >> + struct tty_ldisc *ld = tty_ldisc_ref(tty); >> + >> + if (ld->ops->closing) >> + ld->ops->closing(tty); >> + if (ld) >> + tty_ldisc_deref(ld); >> +} > > That looks strange. Do you need to check ld _before_ dereferencing? Yes. Thanks for noticing. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists