netdev - Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Nov 2015 20:45:25 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, netdev <netdev@...r.kernel.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Subject: Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

On Sun, Nov 15, 2015 at 6:37 PM, David Miller <davem@...emloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Thu, 12 Nov 2015 08:43:18 -0800
>
>> From: Eric Dumazet <edumazet@...gle.com>
>>
>> Some functions access TCP sockets without holding a lock and
>> might output non consistent data, depending on compiler and or
>> architecture.
>>
>> tcp_diag_get_info(), tcp_get_info(), tcp_poll(), get_tcp4_sock() ...
>>
>> Introduce sk_state_load() and sk_state_store() to fix the issues,
>> and more clearly document where this lack of locking is happening.
>>
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>
> Applied, thanks.

Just a heads up that this breaks all arm64 builds in linux-next from
Monday; bisect says:

00fd38d938db3f1ab1c486549afc450cb7e751b1 is the first bad commit
commit 00fd38d938db3f1ab1c486549afc450cb7e751b1
Author: Eric Dumazet
<edumazet@...gle.com>http://kisskb.ellerman.id.au/kisskb/buildresult/12548450/
Date:   Thu Nov 12 08:43:18 2015 -0800

    tcp: ensure proper barriers in lockless contexts

Here is one of the linux-next fails:

http://kisskb.ellerman.id.au/kisskb/buildresult/12548450/

Paul.
--


> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html